feat: add more null types for types the runtime accept or returns as null#363
Merged
NathanWalker merged 1 commit intomainfrom May 4, 2026
Merged
feat: add more null types for types the runtime accept or returns as null#363NathanWalker merged 1 commit intomainfrom
NathanWalker merged 1 commit intomainfrom
Conversation
NathanWalker
approved these changes
May 4, 2026
NathanWalker
pushed a commit
that referenced
this pull request
May 4, 2026
) solves a crash introduced with #363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
| nullin generated.d.tsfiles, matching the runtime behavior where a native null pointer returns JSnull(not aninterop.Pointerwrapping address 0)| nullby default, except when the native API is annotated_Nonnull— preserving type safety for APIs that contractually require a non-null pointerNonNullableTypeto the metadata generator's type system to track_Nonnullannotations from clang, mirroring the existingNullableTypefor_NullableBefore
After
Array types (
interop.Reference<T>fromConstantArray/ExtVector/IncompleteArray) are not affected — they represent inline data that is never null.Test plan
| null(nullable/unannotated) and 2,549 do not (_Nonnull)| nullinterop.Reference<T>withoutinterop.Pointer) are unaffectedNSData.dataWithBytesNoCopyLength(nonnull, no null) vsNSData.dataWithBytesLength(nullable, has null),CGBitmapContextCreate(data:)(nullable, has null)